Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I stop NewPipe 0.27.0 from playing videos in FULL screen? #11025

Open
6 tasks done
shuttittuppitt opened this issue May 1, 2024 · 10 comments
Open
6 tasks done
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) tablet UI Issue is related to Tablet UIs waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed.

Comments

@shuttittuppitt
Copy link

shuttittuppitt commented May 1, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Make sure that you're using version 0.27.0, because this behavior is not in previous versions.
  2. Go to any video's page. (The video's resolution does not affect this, because I've tested this with videos that had 360p (max) & videos that had 1080p & higher).
  3. Going to any video's page will AUTO play that video, & haven't found any setting that changes that. Also, it will auto play that video in FULL screen mode. I haven't found any settings that will change either of those 2 behaviors. (Both of those behaviors are fully related, so this still counts as reporting only one bug.)
  4. The only way to "exit" full screen mode is to use the back button, but doing that stops/pauses the playback of that video.

Expected behavior

(RELEVANT: In previous versions, the expected behavior was either the default behavior, or else it was easy to set it to such in the settings.)
When I go to a specific video's page & click the "Play" button, NewPipe should play that video in "Windowed" mode. (The "Window" is the area of the screen that the video occupies before you click the "Play" button.) If you want to expand the video playback to FULL screen mode, then you would click on the small "[_]" button (bottom right corner of the video) to do so. You could switch between windowed playback & full screen playback without stopping/pausing the video (if you didn't want to stop/pause it).

(There's also the "Popup" player option, but that's not what I mean by "Windowed" playback.)

Actual behavior

(RELEVANT: This behavior was optional & easily avoidable in previous versions.)
When I go to a specific video's page & click the "Play" button, NewPipe 0.27.0 uses FULL screen playback. (Clicking "Fit/fill/zoom" changes the video's appearance, but does not exit full screen playback.) The only available behaviors are full screen playback & don't play the video at all. (There's also the "Popup" player option, but that's not what I mean by "Windowed" playback.)

Screenshots/Screen recordings

A video's resolution does not, affect this, because I've tested this with videos that had 360p (max) & videos that had 1080p & higher. Also, in "Video & audio > Default resolution", I use 720p, but my screen's resolution is at least 1200 x 2000.

This new behavior removes a level of control over videos that previous versions allowed us. Please bring back the ability to switch between "Windowed" playback & full screen playback.

IF the ability to do that is in 0.27.0, tell me exactly which setting I need to change & what I need to change it to. Also, IF the ability to do that is in 0.27.0, change it's location/name so that we won't have to come here & ask you developers where that setting is.

Logs

No response

Affected Android/Custom ROM version

Android 11 & android 14 (both are not rooted)

Affected device model

Samsung galaxy tab A7 & Samsung galaxy tab S9

Additional information

No response

@shuttittuppitt shuttittuppitt added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 1, 2024
@peat80
Copy link

peat80 commented May 1, 2024

Screenshot_20240501-214733

@peat80
Copy link

peat80 commented May 1, 2024

Under settings > video and audio as always.

-Start main player in fullscreen
-Autoplay

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 2, 2024
@shuttittuppitt
Copy link
Author

Sorry for the late response (busy day).
Both "Start main player in full screen" & "Auto play" were already turned off. Turning them back on & then off again does not fix this behavior. It may be specific to tablets (but not phones) or even specific to only Samsung tablets (happens on both my "Samsung galaxy tab A7" & my "Samsung galaxy tab S9"). Tomorrow, I'll record a video of it & the relevant settings, post it on Youtube, & then post a link to it here.

Also, on a guess, I tried rotating my device (to portrait mode), but while that does work, it only fixes this behavior in PORTRAIT mode, which I do not want to use. (Plus, I haven't found any "portrait" (youtube) videos to test that on.) Rotating my device back to landscape mode brings the behavior back.

Does NewPipe have any way to produce a "Logcat" file or some other kind of debug file? If so, I could email that to you. I've heard that there's an (android) program that can do that for other (android) programs, so I'll investigate that too.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 3, 2024
@shuttittuppitt
Copy link
Author

shuttittuppitt commented May 3, 2024

Here is the link to the promised video. I muted the sound while recording it (for file size reasons), so you won't hear anything. Also, while the "Full screen" behavior is demonstrated in this video, it turns out that the "Auto-play" behavior was because I had that (relevant) setting set to "Only on wi-fi". Changing it to "Never" does fix that behavior. I added more information about the video in it's "Description".
https://m.youtube.com/watch?v=kATk6b0tDps

@peat80
Copy link

peat80 commented May 4, 2024

Settings > Appearance > Tablet Mode > On

should give you your desired "windowed view". 😉

@shuttittuppitt
Copy link
Author

shuttittuppitt commented May 4, 2024

That does fix it (finally), but it also causes a different problem. It took me a while to find the link, but the problem that this solution causes is reported here (ironically, the solution to that problem was to set "Tablet mode" to OFF, thereby causing the full screen behavior).
#11020
Despite what I reported (in that bug report), both of my tablets (Samsung galaxy tab A7 (android 11, not rooted) & Samsung galaxy tab S9 (android 14, not rooted)) are affected if "Tablet mode = On".
Essentially, if "Tablet mode = On", then I have extreme difficulty making NewPipe 0.27.0 scroll down (for a video's description), although after several seconds of repeated swiping, it eventually does scroll down. (Sometimes it can take up to 30 seconds of swiping!) So I'm left with either a solution to the full screen behavior or a solution to the "resistance to scrolling down on a video's description", but either solution also causes the other bug!

@opusforlife2
Copy link
Collaborator

As a last resort, try adjusting your Smallest width in Developer options. There might be some threshold value that prevents either or both the bugs, combined with the Tablet mode toggle.

If even that doesn't work, it's possible you'll have to wait for the rewrite to fix this or both bugs.

@opusforlife2 opusforlife2 added waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) tablet UI Issue is related to Tablet UIs and removed needs triage Issue is not yet ready for PR authors to take up labels May 5, 2024
@shuttittuppitt
Copy link
Author

I can't find any setting that is named "Developer options", so where is it located? Also, I expected to have to wait for a future version for a fix since I didn't know that it is possible for a retroactive bug fix. All bug reports that I make (for anybody's programs) are intended to let somebody know that a bug exists, allowing them to fix it in a future update.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 5, 2024
@opusforlife2
Copy link
Collaborator

I can't find any setting that is named "Developer options"

Oh, interesting, are you new to Android? Here's a guide: https://www.xda-developers.com/android-developer-options/

@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 6, 2024
@shuttittuppitt
Copy link
Author

Oh, you mean ANDROID'S developer options. I thought you meant that NewPipe had a setting with that name. It's late now, so I'll try that tomorrow.

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 7, 2024
@opusforlife2 opusforlife2 added the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug GUI Issue is related to the graphical user interface player Issues related to any player (main, popup and background) tablet UI Issue is related to Tablet UIs waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed.
Projects
None yet
Development

No branches or pull requests

3 participants