Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intent-filter so that Invidious /authorize_token links are not opened in NewPipe #11032

Open
6 tasks done
iBicha opened this issue May 3, 2024 · 3 comments
Open
6 tasks done
Labels
feature request Issue is related to a feature in the app

Comments

@iBicha
Copy link

iBicha commented May 3, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.0

Steps to reproduce the bug

  1. Ensure that NewPipe opens Invidious Links by default (deep linking) e.g. invidious.fdn.fr
  2. Open a link for authorizing a token (example)
  • For context, using Playlet you can scan a QR code that directs you to /authorize_token to get a token from Invidious
  1. NewPipe opens instead of the browser, and shows an empty "Content unavailable" page

Expected behavior

NewPipe should not handle /authorize_token links, and let the browser handle it

Actual behavior

NewPipe opens instead of the browser, and shows an empty "Content unavailable" page.

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

NewPipe should not open links that has /authorize_token in them.
I don't know the latest with intent-filters, but if possible, it should handle only the links it can handle (e.g. playlists, videos, channels, etc)
If this is not possible then NewPipe should handle the link and if it finds a /authorize_token it should redirect it back to the default handler/browser

@iBicha iBicha added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 3, 2024
@opusforlife2 opusforlife2 added feature request Issue is related to a feature in the app and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels May 5, 2024
@opusforlife2
Copy link
Collaborator

All front-end URLs are declared in the manifest. I wonder if it can accommodate a denylist of subset paths.

@iBicha
Copy link
Author

iBicha commented May 5, 2024

All front-end URLs are declared in the manifest. I wonder if it can accommodate a denylist of subset paths.

It looks like it's possible to specify a pathAdvancedPattern which can match the url against a regex. This definitely feels like it can solve it. https://developer.android.com/guide/topics/manifest/data-element#path

PS: to confirm, this is not a feature request, this is a bug that breaks Invidious user login

bug

@opusforlife2
Copy link
Collaborator

A workaround is that you disable one specific URL from Newpipe's list and use that to authorise Invidious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

2 participants