You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Brownie config is currently unmarshalled into this structure here.
Proposed solution
Currently, I have a draft PR that includes a Brownie configuration read test, but doesn't modify the common Config structure.
The obvious solution here would probably be to create a separate configuration structure for each provider, because they can have subtle differences, and use that.
Should I open a separate PR that standardizes these configuration reads?
Description
The current go specification that is used to unmarshal Brownie configuration YAML files does not conform to the official Brownie configuration file layout:
tenderly-cli/providers/deployment_provider.go
Lines 22 to 30 in edaae48
The Brownie config is currently unmarshalled into this structure here.
Proposed solution
Currently, I have a draft PR that includes a Brownie configuration read test, but doesn't modify the common
Config
structure.The obvious solution here would probably be to create a separate configuration structure for each provider, because they can have subtle differences, and use that.
Should I open a separate PR that standardizes these configuration reads?
@delta003 @Riphal @mspuz
The text was updated successfully, but these errors were encountered: