Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CampaignManager::Is_Challenge_Campaign just returns false #1074

Open
xezon opened this issue Feb 3, 2024 · 0 comments
Open

CampaignManager::Is_Challenge_Campaign just returns false #1074

xezon opened this issue Feb 3, 2024 · 0 comments
Labels
investigate Investigation and careful discussion needed

Comments

@xezon
Copy link
Contributor

xezon commented Feb 3, 2024

CampaignManager::Is_Challenge_Campaign just returns false

class CampaignManager : public SnapShot
{
public:
...
    bool Is_Challenge_Campaign() const { return false; }
...
}

This makes no sense. It is not even a virtual function.

Perhaps it was meant to be:

bool Is_Challenge_Campaign() const
{
  return (m_currentCampaign != nullptr) ? m_currentCampaign->Is_Challenge_Campaign() : false;
}
@xezon xezon added the investigate Investigation and careful discussion needed label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Investigation and careful discussion needed
Projects
None yet
Development

No branches or pull requests

1 participant