Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The game crashes when a certain 3D Shadow limit is exceeded #53

Open
xezon opened this issue Aug 27, 2021 · 1 comment · May be fixed by TheAssemblyArmada/Thyme#1101
Open

The game crashes when a certain 3D Shadow limit is exceeded #53

xezon opened this issue Aug 27, 2021 · 1 comment · May be fixed by TheAssemblyArmada/Thyme#1101
Assignees
@xezon
Labels
Bug Something is not working right Critical Severity: Minor < Major < Critical < Blocker Executable Is game code related

Comments

@xezon
Copy link
Collaborator

xezon commented Aug 27, 2021 •
edited

The game crashes when a certain 3D Shadow limit (4096) is exceeded.

It is W3DBufferManager that has 4096 buffer size.

Thyme has DX8VertexBufferClass and DX8IndexBufferClass reversed, which use the W3DBufferManager.

Can be tested in test map:
shadow_limit_test_513_scorpions.zip
@xezon xezon added Bug Something is not working right Task A task for someone to work on GenTool Is GenTool related labels Aug 27, 2021
@xezon xezon added the Critical Severity: Minor < Major < Critical < Blocker label Sep 17, 2021
@xezon xezon self-assigned this Sep 17, 2021
@xezon xezon added the Executable Is game code related label Oct 4, 2021
This was referenced Oct 7, 2021
Open
Open
@xezon
Copy link
Collaborator Author

xezon commented Mar 5, 2023

AdrianeYves:

I cannot reproduce it on contra

image

kABUSE:

Any unit that cast 3D shadows will eventually make the game crash. I don't think scorpion are especially prone to this. But as far as I remember ECM tanks are. I can build another test map if you want the exact numbers. My guess would be the more complex the 3D object, the more complex the 3D shadow, the less you need of them to exceed the vortex limit or whatever it is

AdrianeYves:

I tried a different unit from contra. The most detailed one of them all.
The Saturn's shadows do not crash the game. It can achieve crash from max poly only.
Screenshot_135
Screenshot_136
Screenshot_140
crash

@xezon xezon removed Task A task for someone to work on GenTool Is GenTool related labels Mar 5, 2023
@xezon xezon linked a pull request Feb 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xezon xezon

Labels
Bug Something is not working right Critical Severity: Minor < Major < Critical < Blocker Executable Is game code related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix game crash when a shadow buffer limit is exceeded xezon/Thyme
1 participant
@xezon