Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date of Bucket Movements always on the first of the month #240

Closed
Lucaber opened this issue May 11, 2024 · 3 comments · Fixed by #244
Closed

Date of Bucket Movements always on the first of the month #240

Lucaber opened this issue May 11, 2024 · 3 comments · Fixed by #244
Labels
discussion

Comments

@Lucaber
Copy link
Contributor

Lucaber commented May 11, 2024

Hi, is there a reason that bucket movements are always saves with the date of the first in the current month?

https://github.com/TheAxelander/OpenBudgeteer/blob/pre-release/OpenBudgeteer.Core/ViewModels/EntityViewModels/BucketViewModel.cs#L703
https://github.com/TheAxelander/OpenBudgeteer/blob/pre-release/OpenBudgeteer.Core/ViewModels/EntityViewModels/BucketViewModel.cs#L229
@Lucaber Lucaber added the bug label May 11, 2024
@TheAxelander
Copy link
Owner

Yes and no. For calculations and display purposes I need to know in which month a Bucket Movement has happend, the day is not really needed. Instead of using two specific properties/db columns I decided to stick to a Date and just defaulted the day to 1.

@Lucaber
Copy link
Contributor Author

Lucaber commented May 13, 2024

Then setting the current date shouldn't be a problem? I'm asking because the date ist also shown in the transaction history of a bucket and is ordered accordingly to the beginning of a month.

@TheAxelander
Copy link
Owner

Well yes, that would be the only impact

Lucaber added a commit to Lucaber/OpenBudgeteer that referenced this issue May 20, 2024
@Lucaber
Store correct date of bucket movement
bc11f07 
fixes TheAxelander#240
@Lucaber Lucaber mentioned this issue May 20, 2024
Merged
Lucaber added a commit to Lucaber/OpenBudgeteer that referenced this issue May 20, 2024
@Lucaber
Store correct date of bucket movement
17806e5 
fixes TheAxelander#240
TheAxelander pushed a commit that referenced this issue May 25, 2024
@Lucaber @TheAxelander
Store correct date of bucket movement
3c36c64 
fixes #240
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store correct date of bucket movement Lucaber/OpenBudgeteer
2 participants
@Lucaber @TheAxelander