Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid symlinks on Windows #248

Open
Maczuga opened this issue Sep 28, 2023 · 7 comments · May be fixed by #249
Open

Invalid symlinks on Windows #248

Maczuga opened this issue Sep 28, 2023 · 7 comments · May be fixed by #249

Comments

@Maczuga
Copy link

Maczuga commented Sep 28, 2023

v3.4.3, Windows 10

Command: gpth-windoza.exe --copy --input .\Takeout\ --output .\OutTake2
Executed from root of E:\ drive.

All symlinks point towards C:\ALL_PHOTOS instead of E:\OutTake2\ALL_PHOTOS

Same thing happens when I simply run the gpth-windoza via double clicking the executable and point to directories manually.

v3.4.1 works fine, tho symlinks are not relative.

@Maczuga Maczuga linked a pull request Sep 29, 2023 that will close this issue
@Maczuga
Copy link
Author

Maczuga commented Sep 29, 2023

So, apparently there are 2 types of symlinks in Windows that are supported:

  • ink files - shortcuts. Currently created by script. No matter what I do - I am unable to ever create a relative shortcut file and so can't the script.
  • actual symlinks - which you can create via New-Item -ItemType SymbolicLink - those actually can be relative (and you cannot change the path from context menu settings).

I have created a pull request. If you decide that actual symlinks will be OK instead of .ink shortcuts - feel free to pull it.

@aviv926
Copy link

aviv926 commented Dec 4, 2023

I am experiencing the exact same problem here as you
Is there progress with this PR?

@TheLastGimbus
Copy link
Owner

progress with this PR

A progres... well i wouldn't say that... but is it dead? Also no

i'm a bit bussy now so i don't know when i will sit by this - but in some time, i probably will!

@aviv926
Copy link

aviv926 commented Dec 4, 2023

progress with this PR

A progres... well i wouldn't say that... but is it dead? Also no

i'm a bit bussy now so i don't know when i will sit by this - but in some time, i probably will!

Oh sure, thank you very much!
I'll wait

@aviv926
Copy link

aviv926 commented Mar 24, 2024

Hi, is there a fix for this by any chance? Maybe a temporary solution?

@TheLastGimbus
Copy link
Owner

I am really sorry to write that, my status, is still busy 😭😭 And official, branded, and tested solution for that is to be done "soon". BUT! Here is a nightly build of a PR #249 that I still need to review and test myself - but he says it works for him 💯 so you can test it too:

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/8412986115

@aviv926
Copy link

aviv926 commented Mar 27, 2024

I am really sorry to write that, my status, is still busy 😭😭 And official, branded, and tested solution for that is to be done "soon". BUT! Here is a nightly build of a PR #249 that I still need to review and test myself - but he says it works for him 💯 so you can test it too:

https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/8412986115

Man, thanks for your hard work. Take the time you need.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants