fix: prevent showing progress bar on new tab click #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any thoughts? @TheSGJ |
|
Looks like a good fix for this issue! |
|
Good! Waiting for it |
|
This looks like a good PR to me, this should me merged into the main branch |
|
@TheSGJ Can you please check this, it's a useful point. |
|
using this now: https://github.com/tomcru/holy-loader It doesn't have 100% of the customisation features, but is a good drop-in replacement & fixes this bug |
|
Instead of losing on to some features and migrating to some other library, this PR could have been merged, |
|
The PR has been open for ages @Super-Kenil |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #53 and also prevents showing the progress bar altogether on a cmd/ctrl click.
The previous code would still briefly show the progress bar (and load endlessly on Mac).