Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Add missing Spanish translations #9611

Open
karan-rathod-316 opened this issue May 6, 2024 · 7 comments
Open

[refactor]: Add missing Spanish translations #9611

karan-rathod-316 opened this issue May 6, 2024 · 7 comments
Assignees
Labels

Comments

@karan-rathod-316
Copy link
Collaborator

What is the expected behaviour?

When the language is changed to Spanish, all the labels should be in Spanish.

What is the current behaviour?

Currently, only partial labels have Spanish text.
Screenshot 2024-04-30 at 11 51 39 AM

How to reproduce the issue?

  1. Change the language to Spanish by updating the env (LANGUAGE=es)
  2. Login to ToolJet
  3. You can see that only some labels have Spanish text while others don't

If the bug is confirmed, would you be willing to submit a PR?

No

@karan-rathod-316 karan-rathod-316 changed the title [refactor]: Add more spanish translations [refactor]: Add more Spanish translations May 6, 2024
@AkshayKathiriya
Copy link

@karan-rathod-316 I'd like to work on this, can you assign me here.

@2001asjad
Copy link
Collaborator

Hey @AkshayKathiriya, I am assigning this issue to you. Thanks for contributing to ToolJet.

@2001asjad
Copy link
Collaborator

@AkshayKathiriya , are there any updates on this?

@AkshayKathiriya
Copy link

Hii @2001asjad, there is some labels remaining in app builder so working on it, after that will raise PR (Max tomorrow EOD).
Thanks.

@2001asjad
Copy link
Collaborator

Hello @AkshayKathiriya, are there any updates from your side?

@AkshayKathiriya
Copy link

Hi @2001asjad, here is PR.

@karan-rathod-316
Copy link
Collaborator Author

Moving this to review. Thanks @AkshayKathiriya!

@karan-rathod-316 karan-rathod-316 changed the title [refactor]: Add more Spanish translations [refactor]: Add missing Spanish translations May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants