Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button group component selected value type inconsistency with multi-selection #9657

Open
GrowwithNaveen opened this issue May 9, 2024 · 0 comments
Labels
appbuilder bug Something isn't working roadmap

Comments

@GrowwithNaveen
Copy link
Collaborator

GrowwithNaveen commented May 9, 2024

Description
Inconsistency in the data type of the selected value returned by the button group component when used with the "Enable multiple selection" feature.

Current behavior:

  • When "Enable multiple selection" is disabled and a single button is clicked within the group while dragging on the canvas, the selected value is an integer representing the index of the clicked button.
  • When "Enable multiple selection" is enabled and multiple buttons are selected within the group while dragging on the canvas, the selected value becomes a string containing a comma-separated list of button indices.

Expected behavior:
The data type of the selected value should remain consistent regardless of the "Enable multiple selection" setting. Ideally:

  • If a single button is selected (regardless of the multi-selection setting), the selected value should be an integer representing the button's index.
  • If multiple buttons are selected (with multi-selection enabled), the selected value should be an array containing the indices of the selected buttons.

Steps to reproduce:
Please find the below video grab,

Screen.Recording.2024-05-08.at.11.39.08.PM.mov

Note
This was the behavior from initial phase, so there might be users using this. Check for the backward compatibility exhaustively.

@GrowwithNaveen GrowwithNaveen added bug Something isn't working roadmap appbuilder labels May 9, 2024
@GrowwithNaveen GrowwithNaveen changed the title Button group selected value type inconsistency with multi-selection Button group component selected value type inconsistency with multi-selection May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appbuilder bug Something isn't working roadmap
Projects
None yet
Development

No branches or pull requests

1 participant