Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button -> Close modal : Selected modal option for a button to close "on click" using event handler is not retained when a page is duplicated #9674

Open
prajval-tooljet opened this issue May 10, 2024 · 1 comment
Labels
appbuilder bug Something isn't working roadmap

Comments

@prajval-tooljet
Copy link
Collaborator

Version Information

Environment

ToolJet Cloud

What is the expected behaviour?

The selected modal option for the button action to "close a modal" under event handler should always be retained.

What is the current behaviour?

Right now when a page is duplicated all the places where a "on click" button action is implemented to close a modal, the selected modal is not retained when the particular page is duplicated.

How to reproduce the issue?

  1. Add a modal component with buttons in it.
  2. For the added button, create a event handler to close the modal when clicking on the button
  3. Now duplicate that page
  4. In the duplicated page, open the same modal and click on the button to close the modal.
  5. Ideally the modal should close. Check the event handler option for the same button.

Screenshots or Screencast

close-modal.webm

Please provide any traces or logs that could help here.

Any possible solutions?

Can you identify the location in the driver source code where the problem exists?

If the bug is confirmed, would you be willing to submit a PR?

@prajval-tooljet prajval-tooljet added the bug Something isn't working label May 10, 2024
@amit-ksh
Copy link
Contributor

Can I work on this issue??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appbuilder bug Something isn't working roadmap
Projects
None yet
Development

No branches or pull requests

3 participants