New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web prover is not updated in each commitment #545

Open

4 tasks

vivianjeng opened this issue Sep 18, 2023 · 0 comments

Labels

Member

vivianjeng commented Sep 18, 2023

When we update the circuits, the prover tests still take the released key url by default.
Instead, we should update keys in each commitment

upload keys in an r2 or s3 storage
use the tmp url in prover.test.ts (construct the prover like const prover = new WebProver(url))
delete keys from the storage (to save storage)
detect if the test is run in local or circle ci
- in local, we don't run the web prover test, since there is no web prover uploaded
- in circle CI, we run the web prover test

The text was updated successfully, but these errors were encountered:

vivianjeng added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment