Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: new-episode notification appeared and/or not removed after I've marked an episode as watched #776

Open
AndroidDeveloperLB opened this issue Jan 29, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@AndroidDeveloperLB
Copy link

Describe the bug
I've marked an episode as watched, and later got a notification of it.

To Reproduce

  1. Buy the app (SeriesGuide X), and enable notification of it, but after a whole day using the settings.
  2. Suppose you've visited the app before the notification, and marked an episode as watched.

Expected behavior
Notification shouldn't appear, as I've already watched the episode.

Screenshots
Sorry too late.

Smartphone (please complete the following information):

  • Device: Pixel 4
  • OS: Android 11
  • Browser [e.g. stock browser, safari]
    Various, but why would that matter?
  • Version [e.g. 22]
    "57", version code : 2105705.

Additional context
¯_(ツ)_/¯ 

@AndroidDeveloperLB AndroidDeveloperLB added the bug Something isn't working label Jan 29, 2021
@UweTrottmann
Copy link
Owner

Thanks, I'll look into this later. Currently busy with TMDB migration. As I just recently saw the code I don't think there is a bug: before a notification runs it queries for the episodes to show, explicitly including only not watched ones.
Did you maybe use the Android feature to postpone notifications?

@AndroidDeveloperLB
Copy link
Author

@UweTrottmann Perhaps I chose "watched" while it showed the notification, and the notification stayed?

@AndroidDeveloperLB
Copy link
Author

@UweTrottmann I've tested now. If you get a notification, and instead of doing anything with it, you go to the app and mark it as watched, the notification doesn't go away.
Need to test the original thing I reported too, but this is also a bug.

@AndroidDeveloperLB
Copy link
Author

Couldn't see the original issue, but this one does exist.

@UweTrottmann
Copy link
Owner

Thanks, this is currently by design. It would require some additional book-keeping of what notification is currently shown. To then clear it when one of the episodes is marked watched. Maybe if I have some time in the future...

@UweTrottmann UweTrottmann added enhancement New feature or request and removed bug Something isn't working labels Feb 3, 2021
@AndroidDeveloperLB
Copy link
Author

@UweTrottmann Doesn't it have something extra in it, of the ID of the TV series and the episode, to go there?
If the user has marked as watched, maybe you could iterate over the notifications of this kind, and find by this information, and cancel it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants