Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take over updating ThreeTenABP to get latest time zone data? #923

Open
UweTrottmann opened this issue Mar 30, 2023 · 1 comment
Open

Take over updating ThreeTenABP to get latest time zone data? #923

UweTrottmann opened this issue Mar 30, 2023 · 1 comment

Comments

@UweTrottmann
Copy link
Owner

UweTrottmann commented Mar 30, 2023

https://github.com/JakeWharton/ThreeTenABP/ development apparently is winding down and points to using the java.time APIs with Android Plugins' desugaring support.

However, AFAIK this means devices will not have access to the latest time zone data as these updates depend on the manufacturer? https://source.android.com/docs/core/permissions/timezone-rules

Look into this, and possibly take over updating of ThreeTenABP.

Edit: Use case for SeriesGuide: release times might be defined for new time zones. On the other hand, it probably makes sense to stick to time zone data of the device to avoid issues when users use a removed time zone on their device. So using java.time + desugaring might still be an option.

Edit: with the new custom time feature which stores time zone it's more important that all devices support the same time zones. Or find a way to fall back to a more reasonable time zone (currently just always America/New_York).

@JakeWharton
Copy link
Contributor

I am still making releases for tzdb updates for now. It's really easy.

Also note that you can bundle your own tzdb today and use the library by pointing it at yours. Although this has the downside of there being two embedded copies.

The best option for taking over, should it come to that, is to copy out the one class in the library, depend on the no-tzdb variant of ThreeTenBP directly, and embed the TZDB in assets. Not worth a whole fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants