Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - "view graph" page / resizable graph area #32

Open
kirk444 opened this issue Apr 5, 2023 · 4 comments
Open

Feature Request - "view graph" page / resizable graph area #32

kirk444 opened this issue Apr 5, 2023 · 4 comments

Comments

@kirk444
Copy link

kirk444 commented Apr 5, 2023

When using the tool currently, the graph is shown at the very bottom of the page, and the content at the top (instructions / loading lsdb) is not useful when a file is already loaded.

It would be nice to have a way to view the graph so that it would take up most of the page, instead of devoting the top 60% to the "load lsdb" section. Especially for complex topologies this would make it much easier to view and work with the graph.

Minimally, just allowing the "graph area" to be resized so that it can take up more of the page would be helpful. as of not, it can only fill less than half of the vertical space.

@Vadims06
Copy link
Owner

Vadims06 commented Apr 5, 2023

Hi @kirk444 ,
Thank you for your request. I also thought about this, try to add this attributes on upload-ospf page, i.e upload-ospf?show_vendor_options=False&show_vendor_options=False&show_upload_bar=&False and give me feedback.

@kirk444
Copy link
Author

kirk444 commented Apr 5, 2023

I tried to add the parameters, but it doesn't seem to have any effect, maybe I am doing something wrong. I am running this from topolograph-docker and I used the following:
http://localhost:8080/upload-ospf-lsdb?show_vendor_options=False&show_vendor_options=False&show_upload_bar=&False

I also tried without the "-lsdb" (resulted in 404), and I tried without the ampersand before the last "False", but that had no effect either.

@Vadims06
Copy link
Owner

Vadims06 commented Apr 5, 2023

Uh, I forgot that I implemented it on docker-based solution. So try this one vadims06/topolograph:2.32_draft and then open this
http://localhost:8080/upload-ospf-lsdb?show_vendor_options=False&show_vendor_options=False&show_upload_bar=False

@kirk444
Copy link
Author

kirk444 commented Apr 5, 2023

Got it, that works. I do think removing those components is an improvement, but it seems there's still a fixed limitation on the height of the graph section, even in a very tall window, the graph section is limited to a relatively small area vertically.

Similarly, the upper header ("Upload your OSPF/ISIS LSDB") is extremely large, and appears to have a fixed max width, so even in a wide window it takes up two lines (and since the letters are so large that's a significant increase in page height).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants