fix: do not cleanup timeseries which are used in multiple remote write contexts #6206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagen1778
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks for the quick fix!
I'd like to propose additional changes to this PR:
- Add comment to
func (rwctx *remoteWriteCtx) TryPushthat it shouldn't modifytssslice - Add tests which would help to verify vmagent panic on remoteWrite.streamAggr.dedupInterval #6205 vmagent: wrong relabeling via -remoteWrite.urlRelabelConfig #599 and vmagent lost some metrics #467 won't repeat anymore
- Add changelog with bugfix description and affected versions
Signed-off-by: hagen1778 <roman@victoriametrics.com>
* fix the error message comparing in and out series * revert making `newAggregatorsFromData` public, as this introduces unrelated changes. Using `LoadFromFile` instead. Signed-off-by: hagen1778 <roman@victoriametrics.com>
hagen1778
force-pushed
the
do-not-cleanup-ts-in-dedup
branch
from
2d384ec
to
be4d8f4
Compare
hagen1778
pushed a commit
that referenced
this pull request
May 6, 2024
…multiple remote write contexts (#6206) When at least one remote write has deduplication configured it cleans up timeseries while they can be in use by another remote write without deduplication #6205 --------- Signed-off-by: hagen1778 <roman@victoriametrics.com> Co-authored-by: hagen1778 <roman@victoriametrics.com> (cherry picked from commit 8797718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When at least one remote write has deduplication configured it cleans up timeseries while they can be in use by another remote write without deduplication
Fixes #6205
Describe Your Changes
Please provide a brief description of the changes you made. Be as specific as possible to help others understand the purpose and impact of your modifications.
Checklist
The following checks are mandatory: