Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMUI static files are missing in v1.101.0 #6224

Open
lapo-luchini opened this issue May 6, 2024 · 7 comments
Open

VMUI static files are missing in v1.101.0 #6224

lapo-luchini opened this issue May 6, 2024 · 7 comments
Assignees
Labels
bug Something isn't working vmui

Comments

@lapo-luchini
Copy link
Contributor

Describe the bug

When I access /vmui/ I get 404 on generated files.

To Reproduce

http://localhost:8428/vmui/

Version

victoria-metrics-20240426-090403-tags-v1.101.0-0-g5334f0c

Logs

HTTP 404 GET http://localhost:8428/vmui/static/css/main.d0b400e3.css
HTTP 404 GET http://localhost:8428//vmui/static/js/main.59c17910.js

Screenshots

No response

Used command-line flags

No response

Additional information

No response

@lapo-luchini lapo-luchini added the bug Something isn't working label May 6, 2024
@dantangfan
Copy link

face the same problem

image

@hagen1778
Copy link
Collaborator

Hello @dantangfan @lapo-luchini! Do you use official builds provided here https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.101.0 ?

@dantangfan
Copy link

Hello @dantangfan @lapo-luchini! Do you use official builds provided here https://github.com/VictoriaMetrics/VictoriaMetrics/releases/tag/v1.101.0 ?

oh no. I build by myself for test purpose. I run make all cmd in the root dir, and the vminsert app in ./bin/ dir got vmui 404 error.

@lapo-luchini
Copy link
Contributor Author

lapo-luchini commented May 7, 2024

I'm using a locally modified FreeBSD Port that I personally updated to v1.100.1 (and it was working fine, except for #6192) and then to v1.101.0 in commit 5df9610 (and it gives this error).
Using the file from the release page it works fine, but while I can use that release personally (or for testing purposes), the official FreeBSD package (built from the Ports) needs to be locally compiled, so I'll need to fix that anyways in order to have it as a supported package.
PS: I'm not the official maintainer of the port, just a user interested in using a more recent release and advocating for it to be upgraded, so I'd like to send a patch in order to facilitate the process.

@lapo-luchini
Copy link
Contributor Author

I noticed that diff v1.100.1...v1.101.0 shows this:

  "entrypoints": [
    "static/css/main.bc07cc78.css",
-   "static/js/main.034044a7.js"
+   "static/js/main.8e7757ef.js"
  ]

but then the /vmui/ searches for main.59c17910.js.

@lapo-luchini
Copy link
Contributor Author

lapo-luchini commented May 7, 2024

I managed to reproduce on a pristine Linux virtual machine (no relation to FreeBSD):

$ git clone https://github.com/VictoriaMetrics/VictoriaMetrics.git --branch v1.101.0 --depth=1
$ cd VictoriaMetrics
$ make victoria-metrics
APP_NAME=victoria-metrics make app-local
make[1]: Entering directory '/root/VictoriaMetrics'
CGO_ENABLED=1 go build  -ldflags "-X 'github.com/VictoriaMetrics/VictoriaMetrics/lib/buildinfo.Version=victoria-metrics-20240507-112209-tags-v1.101.0-0-g5334f0c'" -o bin/victoria-metrics github.com/VictoriaMetrics/VictoriaMetrics/app/victoria-metrics
make[1]: Leaving directory '/root/VictoriaMetrics'
$ bin/victoria-metrics -httpListenAddr '[::]:18428' &
$ wget -qO - http://localhost:18428/vmui/ | egrep -o 'static/js/main[^"]+'
static/js/main.59c17910.js
$ wget http://localhost:18428/vmui/static/js/main.59c17910.js
--2024-05-07 11:26:45--  http://localhost:18428/vmui/static/js/main.59c17910.js
Resolving localhost (localhost)... ::1, 127.0.0.1
Connecting to localhost (localhost)|::1|:18428... failed: Connection refused.
Connecting to localhost (localhost)|127.0.0.1|:18428... connected.
HTTP request sent, awaiting response... 404 Not Found
2024-05-07 11:26:45 ERROR 404: Not Found.

While on previous version:

$ git clone https://github.com/VictoriaMetrics/VictoriaMetrics.git VM-100 --branch v1.100.1 --depth=1
$ cd VM-100
$ make victoria-metrics
$ bin/victoria-metrics -httpListenAddr '[::]:18428' &
$ wget -qO - http://localhost:18428/vmui/ | egrep -o 'static/js/main[^"]+'
static/js/main.f9cc1e6c.js
$ wget http://localhost:18428/vmui/static/js/main.f9cc1e6c.js
--2024-05-07 11:36:44--  http://localhost:18428/vmui/static/js/main.f9cc1e6c.js
Resolving localhost (localhost)... ::1, 127.0.0.1
Connecting to localhost (localhost)|::1|:18428... failed: Connection refused.
Connecting to localhost (localhost)|127.0.0.1|:18428... connected.
HTTP request sent, awaiting response... 200 OK
Length: 474574 (463K) [text/javascript]
Saving to: 'main.f9cc1e6c.js'

hagen1778 added a commit that referenced this issue May 8, 2024
These files weren't added to the git after `make vmui-build vmui-update` command
in commit 7fd9325#diff-50d9a4b91bdad190f2db92553736267103ab4225dfb6642b675fb4b8196e6560

Related to #6224

Signed-off-by: hagen1778 <roman@victoriametrics.com>
@hagen1778
Copy link
Collaborator

My bad, I forgot to add newly created static files to the git in this commit 7fd9325#diff-50d9a4b91bdad190f2db92553736267103ab4225dfb6642b675fb4b8196e6560

This should be addressed here 56531ab

@hagen1778 hagen1778 self-assigned this May 8, 2024
hagen1778 added a commit that referenced this issue May 10, 2024
These files weren't added to the git after `make vmui-build vmui-update` command
in commit 7fd9325#diff-50d9a4b91bdad190f2db92553736267103ab4225dfb6642b675fb4b8196e6560

Related to #6224

Signed-off-by: hagen1778 <roman@victoriametrics.com>
(cherry picked from commit 56531ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vmui
Projects
None yet
Development

No branches or pull requests

4 participants