-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer_xlsm and Writer_2007 not fully aligned again #1220
Comments
Could you add the exact reproduction steps, without mention to abap2xlsx inner code? |
For better understanding: This is a similar problem as described in #588 which wouldn't have been a problem even back then if #349 (nearly 10 years old) was still fully implemented. The intention of this issue was to revert the redefinition of ZCL_EXCEL_WRITER_XLSM's create method, |
But what is the issue now? If you can't reproduce (actual <> expected), I consider there should be no fix. |
For example:
|
Thanks, so, your two first points are about improving the quality of the XLSX and of the ABAP code, only the third point is a bug according to you. I tag this issue "Enhancement". Please open an issue concerning the third point and propose the minimal ABAP code to reproduce. |
Thanks for approval of #1201.
But I think there could be a problem:
Look at class zcl_excel_writer_xlsm. Method create is a redefinition. Now the changed parameters of method create_xl_sheet_rels does not match to the call in this old redefinition.
Why there still is this redefinition ? The code seems to be anyway not up to date.
In my opinion the only purpose of the redefinition is the call
But this could be also achieved by the standard code in zcl_excel_writer_2007's create method by calling the method add_further_data_to_zip, which is redefined in zcl_excel_writer_xlsm with exactly this code.
The text was updated successfully, but these errors were encountered: