Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IApplicationConfigurationContributor is not auto discovered as documented unless explicitly added to in ConfigureService #19879

Closed
1 task done
nurlix opened this issue May 21, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@nurlix
Copy link

nurlix commented May 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

IApplicationConfigurationContributor is not auto discovered as documented

image

public class MyApplicationConfigurationContributor : IApplicationConfigurationContributor
{
    public Task ContributeAsync(ApplicationConfigurationContributorContext context)
    {
        context.ApplicationConfiguration.SetProperty("userStationId", null);
        return Task.CompletedTask;
    }
}

image

not auto discovered unless
as documented here https://engincanv.github.io/abp/2022/08/02/extending-the-application-configuration-endpoint.html

Configure<AbpApplicationConfigurationOptions>(options =>
{
    options.Contributors.AddIfNotContains(new MyApplicationConfigurationContributor());
});

image

am I missing something?

Reproduction Steps

No response

Expected behavior

No response

Actual behavior

No response

Regression?

No response

Known Workarounds

No response

Version

8.1

User Interface

Angular

Database Provider

EF Core (Default)

Tiered or separate authentication server

None (Default)

Operation System

Windows (Default)

Other information

No response

@nurlix nurlix added the bug label May 21, 2024
@maliming maliming self-assigned this May 21, 2024
@maliming maliming added this to the 8.2-final milestone May 22, 2024
@maliming
Copy link
Member

hi

I will update the document. Change code will bring breaking change. )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants