Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hong Kong - New Payment Icons: AlipayHK and Octopus #422

Open
frankietyng opened this issue Mar 15, 2021 · 5 comments
Open

Hong Kong - New Payment Icons: AlipayHK and Octopus #422

frankietyng opened this issue Mar 15, 2021 · 5 comments

Comments

@frankietyng
Copy link

One of our partners is now adding two additional local wallets: AlipayHK and Octopus. It should be noted that the AlipayHK icon is different from the Alipay (China) icon. Image files for logos attached

For context, this is a QR-code based payment method that will sit within their HPSDK integration alongside other digital wallets like WeChat Pay and FPS.

Help Needed

  1. Add to the admin as a selectable payment method through the QFPay integration
  2. Make the 'AlipayHK' and 'Octopus' icon (attached) visible at checkout when customer is selecting Payment method (=QFPay)

AlipayHK - Logo
Octopus - Logo

@larouxn
Copy link
Collaborator

larouxn commented Mar 15, 2021

Hey @frankietyng, will the partner be able to open a pull request against this repository to add those two new icons?

👋 @shopiwags, are we okay with this new AliPay icon? Considering we just consolidated the other two into one.

@rymwoo
Copy link

rymwoo commented Mar 15, 2021

@frankietyng I'm curious to know who is the partner you've been working with? is it alipay?

@frankietyng
Copy link
Author

@rymwoo Hey - they're called QFPay, aggregating a lot of very local wallets (https://www.qfpay.global/shopify-checkout)
@larouxn asking - thanks :)

@larouxn
Copy link
Collaborator

larouxn commented Mar 18, 2021

@frankietyng, okay, please let me know if the partner will be opening a pull request by Monday. If they cannot, we can probably spin something up. Need to find SVGs of the icons and such though. (open to help finding them)

@zbriscoe, will keep you in the know re: AlipayHK.

@larouxn larouxn mentioned this issue Mar 26, 2021
5 tasks
@larouxn
Copy link
Collaborator

larouxn commented Apr 14, 2021

AliPay HK icon was merged and made live a week or two ago.

Leaving this open as we've yet to add Octopus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants