Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate configuration is not fit for the AEM code sync bot #295

Open
dnbute opened this issue Nov 22, 2023 · 0 comments
Open

Renovate configuration is not fit for the AEM code sync bot #295

dnbute opened this issue Nov 22, 2023 · 0 comments

Comments

@dnbute
Copy link

dnbute commented Nov 22, 2023

Expected Behaviour

When a new project forks the boilerplate, the renovate configuration should not require changes in order to work with the AEM code sync bot.
PRs created by the bot should have test URLs and should just require manual intervention for merge-ing (if not configured to auto-merge).

Actual Behaviour

The recommended config which the boilerplate extends will not have test URLs.
If test URLs are added, they will not work out of the box, because the bot creates branches that include / and . which mess with the url structure and the PSI check will fail to be executed.

Reproduce Scenario (including but not limited to)

See hlxsites/sunstar#276 for example, a PR by the renovate bot that was not merge-able because of the special characters
And see #287 in the boilerplate, that does not have test URLs and as such the PSI check will always fail

Steps to Reproduce

  • Fork the boilerplate
  • Have the Renovate bot create a PR
  • Notice how the PR is not merge-able without admin overrides
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant