Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buttons inside disabled grid list items not being disabled #6324

Merged
merged 3 commits into from
May 21, 2024
Merged

Fix buttons inside disabled grid list items not being disabled #6324

merged 3 commits into from
May 21, 2024

Conversation

joshuajaco
Copy link
Contributor

@joshuajaco joshuajaco commented May 3, 2024 •
edited

Closes #6323

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@joshuajaco joshuajaco marked this pull request as ready for review May 3, 2024 15:59
@reidbarber
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented May 3, 2024

Build successful! 🎉

@rspbot
Copy link

rspbot commented May 3, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

snowystinger
snowystinger approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to revisit this when we do "edit mode". But I think this is fine for now. Thank you for the PR!

@snowystinger snowystinger merged commit 1365cdb into adobe:main May 21, 2024
26 checks passed
@joshuajaco joshuajaco deleted the fix-disabled-grid-list-item-buttons branch May 22, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons inside a GridListItem are not disabled when the item is disabled
6 participants
@joshuajaco @reidbarber @rspbot @snowystinger @LFDanLu @yihuiliao