Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source maps not included for @react-aria packages #6355

Closed
short-dsb opened this issue May 9, 2024 · 4 comments · Fixed by #6368
Closed

Source maps not included for @react-aria packages #6355

short-dsb opened this issue May 9, 2024 · 4 comments · Fixed by #6368
Labels
bug Something isn't working

Comments

@short-dsb
Copy link

short-dsb commented May 9, 2024

Provide a general summary of the issue here

Source maps are not included in the @react-aria packages, resulting in extensive console spam and (presumably) minified errors.

🤔 Expected Behavior?

Source maps are included and there’s no console spam.

😯 Current Behavior

Multiple warnings in the console, for example:

WARNING in ./node_modules/@react-aria/utils/dist/useObjectRef.mjs
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from './node_modules/@react-aria/utils/dist/useObjectRef.mjs.map' file: Error: ENOENT: no such file or directory, open './node_modules/@react-aria/utils/dist/useObjectRef.mjs.map'

💁 Possible Solution

Include the source maps in a new release.

🔦 Context

Console spam makes it difficult to identify actual warnings and errors.

🖥️ Steps to Reproduce

These are visible whenever running an app locally in development mode.

Version

  • @react-aria/interactions 3.21.2
  • @react-aria/ssr 3.9.3
  • @react-aria/utils 3.24.0

What browsers are you seeing the problem on?

Other

If other, please specify.

N/A

What operating system are you using?

N/A

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@short-dsb short-dsb changed the title Source maps not included for @react-aria/utils Source maps not included for @react-aria packages May 9, 2024
@snowystinger
Copy link
Member

snowystinger commented May 9, 2024

Looks like that map is missing for some reason https://www.unpkg.com/browse/@react-aria/utils@3.24.0/dist/ yet maps exist for the others
Thanks for the issue!

@snowystinger snowystinger added the bug Something isn't working label May 9, 2024
@frenicohansen
Copy link

Got the same warning for @internationalized/date. Source maps for .mjs are also missing.

https://unpkg.com/browse/@internationalized/date@3.5.3/dist/

@NamesMT
Copy link

NamesMT commented May 12, 2024

+1 @internationalized/date console spam

NamesMT added a commit to NamesMT/starter-nuxt that referenced this issue May 12, 2024
NamesMT added a commit to NamesMT/starter-fullstack that referenced this issue May 12, 2024
fix: pin `@internationalized/date` bc console spam adobe/react-spectrum#6355
@devongovett
Copy link
Member

devongovett commented May 21, 2024

This is now fixed in a new patch release for all packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants