@internationalized/date — invalid sourcemaps for *.mjs files from v3.5.3

[oedotme]

Provide a general summary of the issue here

Since v3.5.3, most of *.mjs files (perhaps all except import.mjs), point to non-existing source maps.

🤔 Expected Behavior?

1. utils.mjs should contain a sourceMappingURL pointing to utils.module.js.map file:

dist/utils.main.js
dist/utils.main.js.map
dist/utils.mjs            //# sourceMappingURL=utils.module.js.map
dist/utils.module.js
dist/utils.module.js.map

2. Or utils.mjs.map to be generated during build:

dist/utils.main.js
dist/utils.main.js.map
dist/utils.mjs            //# sourceMappingURL=utils.mjs.map
dist/utils.mjs.map        // ←
dist/utils.module.js
dist/utils.module.js.map

😯 Current Behavior

As an example, utils.mjs contains a sourceMappingURL pointing to a non-existing file utils.mjs.map

dist/utils.main.js
dist/utils.main.js.map
dist/utils.mjs            //# sourceMappingURL=utils.mjs.map
dist/utils.module.js
dist/utils.module.js.map

💁 Possible Solution

As mentioned in the expected behavior (1), sourceMappingURL for *.mjs files could point to the corresponding *.module.js.map files.

It seems also that import.mjs points to an "existing" sourcmaps when it's copied from module.js only because the regex pattern doesn't match sourceMappingURL=module.js.map but matches sourceMappingURL=*.module.js.map files:

react-spectrum/scripts/buildEsm.js

Lines 5 to 16 in 45a8728

	let regex = /(.*)\.module\.js/g;
	if (fs.existsSync(`${pkg}/dist/module.js`)) {
	let js = fs.readFileSync(`${pkg}/dist/module.js`, 'utf8');
	js = js.replace(regex, '$1.mjs');
	fs.writeFileSync(`${pkg}/dist/import.mjs`, js);
	}
	for (let file of glob.sync(`${pkg}/dist/*.module.js`)) {
	let js = fs.readFileSync(file, 'utf8');
	js = js.replace(regex, '$1.mjs');
	fs.writeFileSync(file.replace(regex, '$1.mjs'), js);
	}

If that's a possible solution, the regex can be updated to exclude .map matches to preserve the sourceMappingURL:

-      let regex = /(.*)\.module\.js/g;
+      let regex = /(.*)\.module\.js(?!.map)/g;

Update: PR with this change #6368

🔦 Context

No response

🖥️ Steps to Reproduce

N/A

Version

@internationalized/date@3.5.3

What browsers are you seeing the problem on?

Chrome

If other, please specify.

No response

What operating system are you using?

macOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response