-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopen issue 7854 #7963
Comments
Thanks for following up on this. We are unable to see evidence of a memory leak in v31.3.2 See here for comparison: v31.2. https://plnkr.co/edit/BMkZ7eAdb87z2luB?open=index.tsx&preview Can we please ask you to follow this sequence of steps to provide us with more information in regards to this:
This would be the best way forward for us to investigate this further. Much appreciated! Kind regards, |
Hi Zoheil, Thank you for checking this issue out. I noticed three things about your Plunker links:
I analyzed memory with your Plunker examples (which use 31.2.0 AgGrid). Since it had memory leaks (measured about 6 minutes timespan), I created a fork of your code with updated versions (AgGrid 31.3.2 and react 18.2.0). After measuring memory in 10 minutes span, it seems that memory is managed well. So manipulating rowData via AgGrid component prop is probably OK. Back to original issue, applyTransactionAsync, I created a fork of my previous Plunker, mentioned in #7854 : https://plnkr.co/edit/d3MII5h8YswsuN3N?open=index.tsx All measurements I've done were made by taking heap snapshots of "pnklr.co:Main" Javascript VM instance. During the time of measurement, I didn't navigate from selected browser tab, nor did I change viewed file from Plunker file section, located on the left. All browser extensions have been turned off. |
Hello @nikolastojanovictt, Thank you for your thorough review and comment. I have raised another item in our backlog to specifically look at the scenario you've described. We appreciate you forking and providing a most up to date plunker as well. We have added this requirement to our backlog and we are tracking it with the following reference: AG-11669 We have no timeline for this at the moment, but this can still be picked up by our team when they're making modifications to this functional area of AG Grid. Please use the functionality currently provided by AG Grid until this is delivered at a later point. See whether this item will be in the next release by checking the NEXT RELEASE checkbox on the product pipeline page: The best way to track this is to sign up for AG Grid new release notifications using the instructions here. This way you'll know as soon as a new version is out and you can check whether this specific item was implemented on the changelog page. Thanks again for bringing this up with us. Kind regards, |
Issue: #7854
Is marked "DONE" with:
AG-7519 [React] Investigate potential memory leak in React after calling setRowData
in changelog of v31.3.1.
However, issue is still reproducible.
The text was updated successfully, but these errors were encountered: