-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve RefreshableCredentials.token issue #921
Comments
@terrycain just ran into this, any thoughts? Normally this just means overriding a ton more methods :( |
Not come across it yet, yeah it'll probably end up in overriding lots more stuff :( |
@terrycain how did you create your avatar icon btw? very nice! |
ty lol. Not a clue, got given it by a previous company :D |
https://github.com/boto/botocore/blob/e720eefba94963f373b3ff7c888a89bea06cd4a1/botocore/auth.py#L886 From the looks of it, I saw a github issue somewhere saying v4 is required for eu-central-1 so I managed to trigger this using the latest boto3 doing a put_object on a bucket there. Current call stack for a put_object looks roughly like:
iirc we've asyncified most if not all of the main emit logic and general request signing, so it might not be too bad |
Looking a bit more into this before I sleep. https://github.com/aio-libs/aiobotocore/blob/master/aiobotocore/signers.py#L70 - We'll probably need to hijack Then in the signers, asyncify add_auth and _modify_request_before_signing and in there call await get_frozen_credentials All in all my sleep deprived brain doesn't seem to think there'll be much to patch. If I remember I'll have a crack at it Friday evening. Been too long since I've been active in this area :D |
wow didn't expect so much time dedicated to this, hehe, awesome. I ran into this because we're migrating to opensearch which apparently requires SigV4Auth, just created some aiohttp helpers for that, maybe will make some time to make a module for that. I'd post it on a gist but then someone will snarf it before I create a module ;) |
Ok from what I can see. The only place In theory if calling |
we currently disable the
token
property because it needs to be an async call. See: https://github.com/aio-libs/aiobotocore/blob/master/aiobotocore/credentials.py#L259This is called in places like SigV4Auth._modify_request_before_signing which is called by
SigV4Auth.add_auth
. I haven't check upstream who calls this yetThe text was updated successfully, but these errors were encountered: