-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method to drop query keys #898
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #898 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 4 4
Lines 772 781 +9
Branches 219 221 +2
=======================================
+ Hits 770 779 +9
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I really do appreciate that you put in the work for a PR here, but I'd like to first see more discussion about what the API should look like. Can you please first propose this API change in the issue? (I'm not 100% convinced that the name |
Thanks. I think |
49c3b82
to
01091a6
Compare
@mjpieters @hongquan how would you feel about |
Agree with |
The |
@webknjaz I have updated. |
Looks like type stubs need updating.. |
@webknjaz I updated type stub. |
The "Timeline protection" checking job is wrong. It looks for "news" whereas the PR template tells to put to CHANGES. |
What do these changes do?
Add a method,
drop_query_keys
to drop some keys from query part.For example, dropping
"b"
in"a=1&b=2&c=3"
, we get"a=1&c=3"
.Are there changes in behavior for the user?
No.
Related issue number
#774
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.