638% Lottie framework size increase in 4.1.0

[Jon889]

Between Lottie 4.0.1 and 4.1.0 the github release asset xcframework zip size increased from 8.65MB to 18.8MB.

the iOS-arm64 and tvOS-arm64 binaries have jumped from 1.8MB to 13.3MB (638% increase)

This seems quite extreme, is there a reason for this?

[calda]

We use a script to build the XCFramework in CI. That script didn't change between 4.0.1 and 4.1.0.

The XCFramework published by 4.0.1 was built by Xcode 14 / Swift 5.7 and was incompatible with consumers using Xcode 13 / Swift 5.5. In 4.1 we updated our CI job to build the XCFramework using Xcode 13.2.1: #1922. I think I remember this causing the file size to increase.

I'm open to suggestions if you have an idea on how to reduce the size of this XCFramework, as long as we maintain existing backwards compatibility guarantees.

[calda]

After disabling bitcode, the XCFramework is only 8.7mb instead of 18.8mb.

[jshchnz]

@calda We'd be happy to get the Lottie repo set up so that it runs these size comparisons as a status check on all pull requests so issues like this can be caught automatically. For an amazing open source project like Lottie, we'd be happy to offer our Size Analysis service free of charge :)

[calda]

@jshchnz, I'd be open to enabling that functionality in this repo if somebody is willing to post a PR setting it up :)

[noahsmartin]

Here's how I enabled it in my fork: https://github.com/noahsmartin/lottie-ios/pull/3/files#diff-dff4b99d4e651ab9d7597876ec8dbe92aa934e42c0fb55f4aadd6c106fc96688R22 but this uses fastlane which I don't think is used here. So it might require some work to convert to manually calling the API, and finding the right point to run after an xcarchive gets built.

[calda]

I probably don't mind using fastlane for this specific job as long as it's self-contained and doesn't affect the rest of the repo