Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[helm] Should use jobs instead of pods in helm templates. #38062

Open
Pangstar opened this issue May 8, 2024 · 0 comments
Open

[helm] Should use jobs instead of pods in helm templates. #38062

Pangstar opened this issue May 8, 2024 · 0 comments
Assignees
Labels
area/platform issues related to the platform community helm team/deployments type/bug Something isn't working

Comments

@Pangstar
Copy link

Pangstar commented May 8, 2024

Helm Chart Version

0.64.388

What step the error happened?

None

Relevant information

Pods should not be directly referenced in helmcharts. Job wrapper should be applied to improve:

  • Stability in case of NodeFailures: “The Job object will start a new Pod if the first Pod fails or is deleted (for example due to a node hardware failure or a node reboot).”
  • Better retry mechanisms: You can specify exactly how many times a Pod is allowed to fail and restart.
  • Multiple Successes: When you need a task to succeed X times total and then stop running.
  • Parallelism: When multiple Pods can run at the same time

These are the locations of the pod definitions which should be updated to job.

https://github.com/airbytehq/airbyte-platform/blob/main/charts/airbyte/templates/minio.yaml#L106
https://github.com/airbytehq/airbyte-platform/blob/main/charts/airbyte-bootloader/templates/pod.yaml#L3
https://github.com/airbytehq/airbyte-platform/blob/main/charts/airbyte/templates/tests/test-webapp.yaml#L3

ref: https://whyk8s.substack.com/p/why-use-jobs-and-not-bare-pods
ref: https://spacelift.io/blog/kubernetes-jobs
ref: https://kubernetes.io/docs/concepts/workloads/controllers/job/#bare-pods -> "we recommend that you use a Job rather than a bare Pod, even if your application requires only a single Pod. "

Relevant log output

No response

@Pangstar Pangstar added area/platform issues related to the platform needs-triage type/bug Something isn't working labels May 8, 2024
@perangel perangel self-assigned this May 8, 2024
@marcosmarxm marcosmarxm changed the title Should use jobs instead of pods in helm templates. [helm] Should use jobs instead of pods in helm templates. May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform community helm team/deployments type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants