Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add airflow.extraEnvFrom value #514

Open
2 of 3 tasks
mattaltberg opened this issue Feb 2, 2022 · 2 comments · May be fixed by #515
Open
2 of 3 tasks

add airflow.extraEnvFrom value #514

mattaltberg opened this issue Feb 2, 2022 · 2 comments · May be fixed by #515
Labels
kind/enhancement kind - new features or changes status/needs-discussion status - this needs discussion
Projects
Issue Triage and PR Tracking

Comments

@mattaltberg
Copy link

Checks

Motivation

Currently, I have Configmaps and Secrets set up for my cluster. The problem is, to access all of these as environment variables, I need to manually add each a separate env entry, which is very tedious. By adding envFrom as a field to values.yml, I can use the envFrom field to my advantage.

Implementation

Add this block:

{{- if .Values.airflow.extraEnvFrom }}
{{ toYaml .Values.airflow.extraEnvFrom }}
{{- end }}

to pods.tpl after Line 406 (in the block where airflow.envFrom is defined

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@mattaltberg mattaltberg added the kind/enhancement kind - new features or changes label Feb 2, 2022
@matt2930 matt2930 linked a pull request Feb 2, 2022 that will close this issue
Open
6 tasks
@thesuperzapper
Copy link
Member

@mattaltberg I still remain quite against an airflow.extraEnvFrom value, for the same reasons I raised a long time ago in #117 (comment).

The gist of it is that adding this feature will make people try and set airflow configs inside Secrets/ConfigMaps rather than airflow.config, without realizing that pods don't receive environment variable updates from Secrets/Configmaps until they are restarted.

@thesuperzapper thesuperzapper added this to Triage | Waiting for Response in Issue Triage and PR Tracking Mar 22, 2022
@thesuperzapper thesuperzapper moved this from Triage | Waiting for Response to Triage | PR Created in Issue Triage and PR Tracking Mar 22, 2022
@thesuperzapper thesuperzapper moved this from Triage | Work Started to Triage | Hold in Issue Triage and PR Tracking Mar 23, 2022
@thesuperzapper thesuperzapper added the lifecycle/frozen lifecycle - this can't become stale label Mar 23, 2022
@thesuperzapper thesuperzapper changed the title Support using custom envFrom add airflow.extraEnvFrom value Mar 23, 2022
@thesuperzapper thesuperzapper added status/needs-discussion status - this needs discussion and removed lifecycle/frozen lifecycle - this can't become stale labels Mar 23, 2022
@albertjmr
Copy link

albertjmr commented Nov 7, 2023 •
edited

@thesuperzapper is the concern about pods not restarting after config/secret updates still current? The link you posted doesn't seem to point at a heading in the documentation anymore. I wonder if this has changed on recent k8s versions?

UPDATE:
I've now just made a quick test (k8s v1.28) and it still seems to be the case that pods aren't restarted after secrets/config are updated...

Although I'm still curious about the original link to the documentation, I wonder why it has been removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement kind - new features or changes status/needs-discussion status - this needs discussion
Projects
Issue Triage and PR Tracking
Triage | Needs Discussion
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add airflow.extraEnvFrom value mattaltberg/charts
3 participants
@thesuperzapper @mattaltberg @albertjmr