akka.pattern.retry tries one too many times

[monktastic]

akka.pattern.retry takes a param called attempts, but it tries attempts+1 times. Simplified version of RetrySupport.retry:

    if (maxAttempts - attempted > 0) {
      val result = tryAttempt()
      retry(attempt, maxAttempts, delayFunction, attempted + 1)
    } else {
      tryAttempt()
    }
  }

If maxAttempts=0 and attempted=0, it will still try. If maxAttempts=1 it will try twice. And so on.

[johanandren]

It is not really attempts but rather maxRetries (the first call isn't a retry). Not sure it is worth changing though, parameter names are part of method signature on the Scala side. Maybe worth spelling out in the API docs.