Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech debt] Move all random sampling to get_params and get_params_depend_on_targets #1653

Open
2 tasks
ternaus opened this issue Apr 11, 2024 · 0 comments
Open
2 tasks

[Tech debt] Move all random sampling to get_params and get_params_depend_on_targets #1653

ternaus opened this issue Apr 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ternaus
Copy link
Collaborator

ternaus commented Apr 11, 2024

  • Move all random calculation from apply_xxx, __init__ to get_params_depend_on_targets
  • Add pre-commit hook that checks that there is no random in apply_xxx and __init__
@ternaus ternaus added the enhancement New feature or request label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ternaus