Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking first screen may crash JS #1464

Closed
Thomas-git opened this issue Feb 27, 2024 · 6 comments
Closed

Booking first screen may crash JS #1464

Thomas-git opened this issue Feb 27, 2024 · 6 comments

Comments

@Thomas-git
Copy link

Thomas-git commented Feb 27, 2024

How to reproduce:
Use dev version (stable release is not affected)
Add 4 or more services to one provider.
Go to booking page
Select service1 then service2, then service3 then service4. Go back to service one (yes you are a very fussy customer).

It makes JS hang, the page become unusable and you have to reload page. Tested on chrome and firefox. Mobil and desktop, same issue.

I'd be more that happy to solve this but I don't know where to look at in the first place.

@Thomas-git
Copy link
Author

It seems to happen only when the last service is selected. What script is call on service selection?

@alextselegidis
Copy link
Owner

Hello!

This could be because each service change will trigger an HTTP request to fetch availability.

In any case the script that has this logic is frontend_book.js

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@alextselegidis
Copy link
Owner

Hello!

Are there any error messages related to this problem?

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

@Thomas-git
Copy link
Author

No error message. I didn't had time to spend on this. Maybe next week. My first thought is to add a debounce on the fetch request. But maybe you’ve already done this. I still have to look at the code.

@alextselegidis
Copy link
Owner

There were some updates lately in the booking screen. Can you please check with the latest 1.5.0-alpha.1 release and see if this is still an issue?

@alextselegidis
Copy link
Owner

Closing due to inactivity, feel free to post more info so that we can pick this up again.

Alex Tselegidis, Easy!Appointments Creator
Need a customization? Get a free quote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants