Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI]thread safety issues with TongYiChatClient TongYiChatClient线程安全问题 #3719

Closed
sailorzheng opened this issue May 8, 2024 · 2 comments

Comments

@sailorzheng
Copy link

AI TongYiChatClient
spring cloud alibaba version:2023.0.1.0

The Alibaba Cloud DashScope official website mentions that Generation Class is not thread-safe. However, in the Spring Cloud Alibaba AI, the TongYiChatClient is a singleton, and the Generation it holds is also a singleton. Could you please clarify if there might be any thread safety issues with TongYiChatClient?
阿里云 DashScope官网中提到Generation不是线程安全的,但看spring cloud alibaba ai中的TongYiChatClient是单例的 ,并且其持有的Generation也是单例的,麻烦问下是否会TongYiChatClient 是否会有线程安全问题呢
image
image

I have read the reference doc of spring ai and spring cloud alibaba ai

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented May 9, 2024

According to the description on the website, it does have a security issue, can you submit a pr to finish it? @sailorzheng

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented May 9, 2024

/kind question
/area ai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants