Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hand matting option sometimes doesn't follow toggle box when launching VR, after app was backgrounded at least once #58

Open
shinyquagsire23 opened this issue Feb 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@shinyquagsire23
Copy link
Collaborator

Sometimes the app doesn't fully clean up and seems to reuse the existing immersive scene, with incorrect settings? Or something, I'm not sure what it's doing.

@shinyquagsire23 shinyquagsire23 added the bug Something isn't working label Feb 26, 2024
@shinyquagsire23
Copy link
Collaborator Author

This might actually be a visionOS bug because I just had it change mid-session after opening Control Center, lol

@shadowfacts
Copy link
Collaborator

Actually, I think I missed this in my PR review. Here, the GlobalSettings instance should be in an @ObservedObject in the app struct, so that SwiftUI tracks the dependency properly: https://github.com/alvr-org/alvr-visionos/blob/main/ALVRClient/ALVRClientApp.swift#L77

Or GlobalSettings could use @Observable, in which case the dependency would be picked up without needing the additional property wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants