Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amber g creates system tests that are incomplete for controller/request testing #1320

Open
crimson-knight opened this issue May 20, 2023 · 0 comments

Comments

@crimson-knight
Copy link
Member

When using the api generator like:

amber g api examplething name:string

Everything generates properly, however when you run the tests you'll get errors like:

response = subject.get "/examplething"

This is because the GarnetSpec::RequestHelper isn't being included in the controller test class that is being generated.

This is definitely being missed in our test coverage as well.

  1. Fix the generators to ensure everything generating a system/controller test is including the necessary module.
  2. Add test coverage to check that everything is being included in the generator files.
  3. Add a workflow to CircleCI that creates an amber app and then runs the generator and runs the spec suite. Everything for a brand new app should run without issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant