Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gpu-poly module more memory safe #12

Open
andrewmilson opened this issue Nov 14, 2022 · 0 comments
Open

Make gpu-poly module more memory safe #12

andrewmilson opened this issue Nov 14, 2022 · 0 comments
Labels
help wanted Extra attention is needed refactor Can be written more cleanly

Comments

@andrewmilson
Copy link
Owner

andrewmilson commented Nov 14, 2022

Currently miniSTARK passes around *mut pointers when sharing memory addresses with GPU code in a rather unsafe manner. Would be great if this memory was wrapped in some way to allow rust to enforce memory safety. Will be good to keep the memory challenges with #2 in mind with this work. A couple of the problematic functions to understand the issue:

  • buffer_no_copy
  • buffer_mut_no_copy

In addition to these changes any types being sent for processing to the gpu should be represented in memory as you would expect from C or C++.

@andrewmilson andrewmilson added help wanted Extra attention is needed refactor Can be written more cleanly labels Nov 14, 2022
@andrewmilson andrewmilson changed the title Make miniSTARK's Rust GPU interfaces more memory safe Make gpu-poly module more memory safe Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed refactor Can be written more cleanly
Projects
None yet
Development

No branches or pull requests

1 participant