Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR]: Jetchat is not laid out edge-to-edge in 2 & 3-button navigation mode #1256

Closed
3 tasks done
manabu-nakamura opened this issue Feb 14, 2024 · 2 comments
Closed
3 tasks done

[FR]: Jetchat is not laid out edge-to-edge in 2 & 3-button navigation mode #1256

manabu-nakamura opened this issue Feb 14, 2024 · 2 comments
Assignees
@florina-muntenescu
Labels
enhancement New feature or request stale triage me Issue that needs to be triaged

Comments

@manabu-nakamura
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is this a feature request for one of the samples?

  • Yes, this is a specific request related to this samples repo.

Sample app

Jetchat

Describe the problem

Jetchat is not laid out edge-to-edge in 2 & 3-button navigation mode (it is not drawn behind the system navigation bar in 2 & 3-button navigation mode).
Screenshot_20240213_232305

Describe the solution

Jetchat is laid out edge-to-edge in 2 & 3-button navigation mode (it is drawn behind the system navigation bar in 2 & 3-button navigation mode).
Screenshot_20240213_232354

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@manabu-nakamura manabu-nakamura added enhancement New feature or request triage me Issue that needs to be triaged labels Feb 14, 2024
@manabu-nakamura manabu-nakamura mentioned this issue Feb 14, 2024
Merged
bentrengrove added a commit that referenced this issue Feb 14, 2024
@bentrengrove
Jetchat is not laid out edge-to-edge in 2 & 3-button navigation mode (#…
66b8317 
…1257)

#1256

(before) Jetchat is not laid out edge-to-edge in 2 & 3-button navigation
mode (it is not drawn behind the system navigation bar in 2 & 3-button
navigation mode).

![Screenshot_20240213_232305](https://github.com/android/compose-samples/assets/71050561/e2cb2c04-74a8-4b6b-8cf7-b9f7756ec425)
(after) Jetchat is laid out edge-to-edge in 2 & 3-button navigation mode
(it is drawn behind the system navigation bar in 2 & 3-button navigation
mode).

![Screenshot_20240213_232354](https://github.com/android/compose-samples/assets/71050561/4ca9f268-8c64-4d08-964b-8b553fbf9642)
@sothsokna
Copy link

Needs help

@stale Stale
Copy link

stale bot commented May 25, 2024

This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.

@stale stale bot added the stale label May 25, 2024
@stale stale bot closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@florina-muntenescu florina-muntenescu

Labels
enhancement New feature or request stale triage me Issue that needs to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@florina-muntenescu @manabu-nakamura @sothsokna