Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interests and Topic feature modules should be merged #1414

Open
dturner opened this issue May 3, 2024 · 1 comment
Open

Interests and Topic feature modules should be merged #1414

dturner opened this issue May 3, 2024 · 1 comment

Comments

@dturner
Copy link
Collaborator

dturner commented May 3, 2024

Previously we had an authors module so the module structure was:

  • interests
    • authors
    • topics

Now that we no longer have authors, the nested structure adds complexity for no benefit, making it especially difficult to understand the navigation graph. Suggest merging :topics into :interests (whilst keeping the Topic model).

This would enable InterestsListDetailScreen which is currently in the :app module to be moved into the feature module.

@Jaehwa-Noh
Copy link
Contributor

Jaehwa-Noh commented May 4, 2024

The merged two modules, seemed too big and coarse grained to me.
What about just moving InterestListDetailScreen and Interests2PaneViewModel into :interests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants