Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(docs-infra): change link #55688

Closed
wants to merge 1 commit into from
Closed

docs(docs-infra): change link #55688

wants to merge 1 commit into from

Conversation

vladboisa
Copy link
Contributor

@vladboisa vladboisa commented May 6, 2024 •
edited

Fix url link for Button Change detection usage

Fixes #55687

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from crisbeto May 6, 2024 17:03
@angular-robot angular-robot bot added the area: docs Related to the documentation label May 6, 2024
@ngbot ngbot bot added this to the Backlog milestone May 6, 2024
@vladboisa
docs(docs-infra): change link
1d7e348 
Fix url link for Button Change detection usage

Fixes #556687
@vladboisa vladboisa force-pushed the fix_viewRef_links branch 3 times, most recently from 918e28b to 1d7e348 Compare May 7, 2024 16:11
@vladboisa vladboisa requested a review from JeanMeche May 7, 2024 16:14
bencodezen
bencodezen approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vladboisa!

@bencodezen bencodezen added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels May 20, 2024
@pkozlowski-opensource pkozlowski-opensource removed the request for review from crisbeto May 23, 2024 09:57
@pkozlowski-opensource pkozlowski-opensource added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label May 23, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 8250238.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@JeanMeche JeanMeche JeanMeche approved these changes

@bencodezen bencodezen bencodezen approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

ViewRef broken "Change detection usage" link doesn't work
4 participants
@vladboisa @pkozlowski-opensource @JeanMeche @bencodezen