Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign Record Processing #38

Open
mariari opened this issue Jul 14, 2022 · 1 comment
Open

Redesign Record Processing #38

mariari opened this issue Jul 14, 2022 · 1 comment
Labels
enhancement New feature or request Polish

Comments

@mariari
Copy link
Member

mariari commented Jul 14, 2022

Currently I have two big pieces of logic in pass

  • relocation
  • expansion

Relocations job is to find the records which should be expanded away, and give a map and a closure related to do this task.

Expansion has the job of searching where things should be expanded and placing the proper information.

I think this model worked in the past before we had to consider packing data.

Now that we've had to deal with wanting packed and unpacked data, a much better model can be formed.

  1. Use the closure as a context mapping of names.
    • Thus it contains the following information
      1. the type
      2. the unpacked names
      3. the packed names
      4. What state the value is naturally in
      5. Requesting to generate the other state?
  2. Many operations may care about the packed or unpacked status of a value
@mariari
Copy link
Member Author

mariari commented Oct 11, 2022

Further the new work from VAMP-IR shows that they now support records, meaning that a bulk of the work can be simplified for this use case.

Current Issues caused by the new VAMP-IR version

  1. We can't take tuples, instead we expand out all arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Polish
Projects
None yet
Development

No branches or pull requests

1 participant