Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancelled vs canceled - standardize spelling in codebase #15177

Open
6 of 11 tasks
rebeccahhh opened this issue May 9, 2024 · 2 comments
Open
6 of 11 tasks

cancelled vs canceled - standardize spelling in codebase #15177

rebeccahhh opened this issue May 9, 2024 · 2 comments

Comments

@rebeccahhh
Copy link
Member

rebeccahhh commented May 9, 2024

Please confirm the following

  • I agree to follow this project's code of conduct.
  • I have checked the current issues for duplicates.
  • I understand that AWX is open source software provided for free and that I might not receive a timely response.
  • I am NOT reporting a (potential) security vulnerability. (These should be emailed to security@ansible.com instead.)

Bug Summary

There are a couple of places that still use "cancelled" even though AWX appears to have standardized "canceled"
https://github.com/search?q=repo%3Aansible%2Fawx%20cancelled&type=code <- only one in particular looks to be problematic from a functionality perspective within the UI for WSRelay.
I have not tested this to know if it impacts functionality though.

AWX version

24.3.1

Select the relevant components

  • UI
  • UI (tech preview)
  • API
  • Docs
  • Collection
  • CLI
  • Other

Installation method

docker development environment

Modifications

no

Ansible version

n/a

Operating system

n/a

Web browser

n/a

Steps to reproduce

search codebase for "cancelled" or "canceled" and compare

Expected results

n/a

Actual results

n/a

Additional information

No response

@TheRealHaoLiu
Copy link
Member

tagged as good-first-issue

if anyone is interested in contributing, contribution are welcome and appreciated

@abreyaustin
Copy link

Working on this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants