Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Infer Colourscheme #3735

Open
juliansommer opened this issue Apr 22, 2024 · 0 comments
Open

GitHub Infer Colourscheme #3735

juliansommer opened this issue Apr 22, 2024 · 0 comments
Labels
bug Something isn't working.

Comments

@juliansommer
Copy link

juliansommer commented Apr 22, 2024

Describe the bug

While using code from the GitHub example on inferring colour scheme to display different images, it would miss the 2nd one eg hide=contribs,issues. Sometimes it would randomly work and othertimes it wouldn't. I fixed it by url encoding the commas in my links. Its a weird issue as going to the link itself in a tab produced the correct image, but viewing it on my GitHub README would skip the 2nd input. This was not an issue when using the markdown theme like this (but I needed to centre it so had to use the other one).
[![Anurag's GitHub stats-Dark](https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true&theme=dark#gh-dark-mode-only)](https://github.com/anuraghazra/github-readme-stats#gh-dark-mode-only) [![Anurag's GitHub stats-Light](https://github-readme-stats.vercel.app/api?username=anuraghazra&show_icons=true&theme=default#gh-light-mode-only)](https://github.com/anuraghazra/github-readme-stats#gh-light-mode-only)

Expected behavior

The image displayed on the GitHub README is the same as the image displayed by going to the link in the browser. In the Images below the README should be hiding issues and contribs.

Here's one of the commits. You can see the &count_private flag is not being registered because GitHub is stopping the link at the comma.

Screenshots / Live demo link

On GitHub README
On GitHub README
On Webpage
On Webpage

What to do

just add a note to the README that commas should be url encoded

@juliansommer juliansommer added the bug Something isn't working. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

1 participant