You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When using scan servers and the default plugins if the set of scan servers is empty, then the default plugin will fall back to tablet severs. Depending on how resources are allocated this may be undesirable and cause problems. Scan servers would be more useful if it was possible to wait for scan servers when none currently exists.
Describe the solution you'd like
Add an option to ConfigurableScanServerSelector for waiting on scan servers. This could look like the following where "waitForScanServers":true is the new option.
Support for this new option could be added by having the ConfigurableScanServerSelector loop where it sleeps and checks the set of scan servers.
Scanners can have timeouts set, so waiting in the plugin could violate those timeouts. To handle this, may want to add support to the SPI for waiting that takes the scanner timeouts into consideration. Could add support to ScanServerSelector.SelectorParameters for waiting
interfaceSelectorParameters {
/** * Determines if a scan server selector can wait for a conditoin to be true (like scan servers to be present). If this returns true and the desired state is not met, then throw a timed out exception. */booleanhasTimedOut();
}
Then ConfigurableScanServerSelector could call the hasTimedOut() function in its loop waiting for non zero tservers. Adding support for timeouts to the SPI could be follow on work.
The text was updated successfully, but these errors were encountered:
I think it makes sense for the ConfigurableScanServerSelector to wait for ScanServers to be available instead of immediately falling back to TabletServers. However, I think there should be a timeout set, I don't think the client should wait forever.
I think it makes sense for the ConfigurableScanServerSelector to wait for ScanServers to be available instead of immediately falling back to TabletServers. However, I think there should be a timeout set, I don't think the client should wait forever.
Instead of the config being a boolean, it could be a timeout. Maybe something like the following.
Is your feature request related to a problem? Please describe.
When using scan servers and the default plugins if the set of scan servers is empty, then the default plugin will fall back to tablet severs. Depending on how resources are allocated this may be undesirable and cause problems. Scan servers would be more useful if it was possible to wait for scan servers when none currently exists.
Describe the solution you'd like
Add an option to ConfigurableScanServerSelector for waiting on scan servers. This could look like the following where
"waitForScanServers":true
is the new option.Support for this new option could be added by having the ConfigurableScanServerSelector loop where it sleeps and checks the set of scan servers.
Scanners can have timeouts set, so waiting in the plugin could violate those timeouts. To handle this, may want to add support to the SPI for waiting that takes the scanner timeouts into consideration. Could add support to ScanServerSelector.SelectorParameters for waiting
Then ConfigurableScanServerSelector could call the
hasTimedOut()
function in its loop waiting for non zero tservers. Adding support for timeouts to the SPI could be follow on work.The text was updated successfully, but these errors were encountered: