Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assess which micrometer metrics Counters can be converted to FunctionCounters #4540

Closed
DomGarguilo opened this issue May 9, 2024 · 0 comments · Fixed by #4555
Closed

Assess which micrometer metrics Counters can be converted to FunctionCounters #4540

DomGarguilo opened this issue May 9, 2024 · 0 comments · Fixed by #4555
Assignees
@DomGarguilo

Comments

@DomGarguilo
Copy link
Member

DomGarguilo commented May 9, 2024 •
edited

If these are monotonically increasing counters, then it would be better to use a FunctionCounter instead of a Gauge. Not sure if they are, need to investigate. The micrometer code to instrument caches uses FunctionCounter internally

Originally posted by @keith-turner in #4518 (comment)

We should look at the places we are using a Counter and determine if it is a good idea to convert them to FunctionCounter.
@DomGarguilo DomGarguilo changed the title Asses which micrometer metrics Counters can be converted to FunctionCounters Assess which micrometer metrics Counters can be converted to FunctionCounters May 9, 2024
@DomGarguilo DomGarguilo self-assigned this May 9, 2024
@DomGarguilo DomGarguilo mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DomGarguilo DomGarguilo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert micrometer Counters to FunctionCounters DomGarguilo/accumulo
1 participant
@DomGarguilo