Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on May 12, 2024 #39578

Closed
24 of 66 tasks
eladkal opened this issue May 12, 2024 · 14 comments
Closed
24 of 66 tasks

Status of testing Providers that were prepared on May 12, 2024 #39578

eladkal opened this issue May 12, 2024 · 14 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented May 12, 2024

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

The guidelines on how to test providers can be found in

Verify providers by contributors

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 8.22.0rc1

Provider apache.iceberg: 1.0.0rc1

Provider google: 10.18.0rc2

Provider microsoft.azure: 10.1.0rc2

Provider pinecone: 2.0.0rc2

Provider tabular: 1.5.1rc1

All users involved in the PRs:
@kacpermuda @e-galan @moiseenkov @Taragolis @keygrocery @o-nikolas @romsharon98 @dondaum @rawwar @dstandish @dabla @MaksYermak @CYarros10 @Kylea650 @wlinamchurch @tatiana @idantepper @tomrutter @Ferruzz

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels May 12, 2024
@Kylea650
Copy link
Contributor

#39156 tested and working. #39466 added as a result of testing (small documentation change). This has been approved but hasn’t yet been merged in.

airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue May 13, 2024
@moiseenkov
Copy link
Contributor

Hi,
#38894, #39233, #39171, #39234, #39434 work as expected

@dabla
Copy link
Contributor

dabla commented May 13, 2024

Hello, I tested following PR and they are all working a expected:

So for me everything related to MSGraphOperator is good.

@VladaZakharova
Copy link
Contributor

Hi!
#39206 works as expected

@wlinamchurch
Copy link
Contributor

#38911 works as expected

@dondaum
Copy link
Contributor

dondaum commented May 13, 2024

#38961 is good ✅

@e-galan
Copy link
Contributor

e-galan commented May 14, 2024

#39018 and #37693 work as expected.

System tests for #38584 are failing. CreateCustomTrainingJobOperator has a problem with training new models that are based on parent models. It seems that there is a problem with parsing and validating the parent model's resource id. The problem occurs immediately after submitting a child model's training job, when we wait for gca resource creation. It happens both for sync and deferrable modes.

Addressed in #39640

@molcay
Copy link
Contributor

molcay commented May 14, 2024

#39432 and #38673 works as expected

@VladaZakharova
Copy link
Contributor

Hi @eladkal !
Since #38584 is not working as expected, we will prepare a fix for it ASAP. Can we please discuss if we can have RC3 for google-provider in this case with that fix?

@eladkal
Copy link
Contributor Author

eladkal commented May 15, 2024

Hi @eladkal ! Since #38584 is not working as expected, we will prepare a fix for it ASAP. Can we please discuss if we can have RC3 for google-provider in this case with that fix?

We can but I'd prefer to release RC2 and have the fix released in next wave (plan to cut it during the weekend)
The current RC2 is massive. I am not sure if it's right to hold it's release due to the reported issue. I think releasing it and applying a quick followup hot fix is a good balance. WDYT?

@VladaZakharova
Copy link
Contributor

Hi @eladkal ! Since #38584 is not working as expected, we will prepare a fix for it ASAP. Can we please discuss if we can have RC3 for google-provider in this case with that fix?

We can but due I'd prefer to release RC2 and have the fix released in next wave (plan to cut it during the weekend) The current RC2 is massive. I am not sure if it's right to hold it's release due to the reported issue. I think releasing it and applying a quick followup hot fix is a good balance. WDYT?

Sounds good to me, thank you!

@e-galan
Copy link
Contributor

e-galan commented May 15, 2024

Hi @VladaZakharova @eladkal !

The fix for #38584 is implemented in #39640 .

@shahar1
Copy link
Contributor

shahar1 commented May 17, 2024

#39315 works as expected (issue #39127 can be closed)

@eladkal
Copy link
Contributor Author

eladkal commented May 17, 2024

Thank you everyone. Providers are released.
pinecone provider is excluded and will have rc3

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@eladkal eladkal closed this as completed May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

10 participants