Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: clean the resource when optimizer instance expired #2714

Closed
3 tasks done
Yao-MR opened this issue Apr 3, 2024 · 1 comment
Closed
3 tasks done

[Improvement]: clean the resource when optimizer instance expired #2714

Yao-MR opened this issue Apr 3, 2024 · 1 comment

Comments

@Yao-MR
Copy link

Yao-MR commented Apr 3, 2024

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

when release the optimizer, the amoro will remove the resource in the and then remove the instance

when the optimizer expired, the amoro will remove the instance and will not remove resouce in the db, which will cause this dirty data,

How should we improve?

we should flow the step when release the optimzier, when we detect the optimizer instance expired, not only should we remove the optimzier, we also should remove the resource record in the db

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@majin1102
Copy link
Contributor

Thanks for raising this issue.

Can you point out the influence of this improvement? or what have you encountered.
I think expiring and deleting are somehow different operation

@Yao-MR Yao-MR closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants