Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: align term 'transaction' with Iceberg 'snapshot' #2751

Open
3 tasks done
link3280 opened this issue Apr 16, 2024 · 2 comments
Open
3 tasks done

[Improvement]: align term 'transaction' with Iceberg 'snapshot' #2751

link3280 opened this issue Apr 16, 2024 · 2 comments

Comments

@link3280
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, snapshots are called transactions both in the codebase and the web UI, but under the hood they're the same
for Iceberg users (perhaps some functionalities improvement for mixed formats).

I proposed to rename transactions to snapshots, which is more understandable for new users.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@majin1102
Copy link
Contributor

majin1102 commented Apr 27, 2024

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing....
You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

@link3280
Copy link
Contributor Author

link3280 commented May 3, 2024

There's context for this.

Amoro name transacions on snapshots which are not produced by amoro optimizing.... You could see transactions and optimized two tabs. Both of them consists all snapshots.

We could discuss furthur if this is necessary

@majin1102 Thanks for your input. I suppose you mean add-on transaction capabilities (e.g. transaction blockers) provided by mixed formats? But if I understand correctly there's no fundamental difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants