Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Improve ams metrics module naming #2797

Closed
2 of 3 tasks
majin1102 opened this issue Apr 28, 2024 · 0 comments · Fixed by #2798
Closed
2 of 3 tasks

[Improvement] Improve ams metrics module naming #2797

majin1102 opened this issue Apr 28, 2024 · 0 comments · Fixed by #2798
Labels
type:improvement

Comments

@majin1102
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Refered to Iceberg, Paimon, Hudi and Flink.

Only Flink has a module named as flink-metrics which has quite similar logic to Amoro:
image

When it comes to Paimon, Hudi and Iceberg, they all have packages named as metrics.

I think metric-reporter is too granular and metrics should be reasonable for both extensibility and readibility.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AMORO-2797] Improve ams metrics module naming majin1102/amoro
1 participant
@majin1102