Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C#] Eliminate compiler warnings when building the project #41602

Closed
CurtHagenlocher opened this issue May 9, 2024 · 3 comments · Fixed by #41645
Closed

[C#] Eliminate compiler warnings when building the project #41602

CurtHagenlocher opened this issue May 9, 2024 · 3 comments · Fixed by #41645
Assignees
@CurtHagenlocher
Labels
Component: C# Type: bug
Milestone
17.0.0

Comments

@CurtHagenlocher
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

A build should not produce compiler warnings.

Component(s)

C#
@CurtHagenlocher CurtHagenlocher self-assigned this May 9, 2024
CurtHagenlocher added a commit to CurtHagenlocher/arrow that referenced this issue May 9, 2024
@CurtHagenlocher
Eliminate compiler warnings.
bb46055 
Closes apache#41602
@CurtHagenlocher CurtHagenlocher mentioned this issue May 9, 2024
Closed
@voidstar69
Copy link
Contributor

Has the WarningsAsErrors project flag been considered, to avoid compiler warnings creeping into PRs/builds?

@CurtHagenlocher
Copy link
Contributor Author

Has the WarningsAsErrors project flag been considered, to avoid compiler warnings creeping into PRs/builds?

Fantastic idea!

CurtHagenlocher added a commit to CurtHagenlocher/arrow that referenced this issue May 13, 2024
@CurtHagenlocher
Eliminate compiler warnings.
0e3564c 
Closes apache#41602
@CurtHagenlocher CurtHagenlocher mentioned this issue May 13, 2024
Closed
CurtHagenlocher added a commit to CurtHagenlocher/arrow that referenced this issue May 14, 2024
@CurtHagenlocher
Resolve or disable all warnings. Configure projects to produce an err…
9f55980 
…or on warnings.

Closes apache#41602
@CurtHagenlocher CurtHagenlocher mentioned this issue May 14, 2024
Merged
CurtHagenlocher added a commit that referenced this issue May 14, 2024
@CurtHagenlocher
GH-41602: [C#] Resolve build warnings (#41645)
e411e0e 
### What changes are included in this PR?

Adds annotations or suppressions to disable build warnings. Configures projects to produce an error on warnings.

### Are these changes tested?

Changes are covered by existing tests.

Closes #41602

* GitHub Issue: #41602

Authored-by: Curt Hagenlocher <curt@hagenlocher.org>
Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
@CurtHagenlocher
Copy link
Contributor Author

Issue resolved by pull request 41645
#41645

@CurtHagenlocher CurtHagenlocher added this to the 17.0.0 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CurtHagenlocher CurtHagenlocher

Labels
Component: C# Type: bug
Projects
None yet
Milestone
17.0.0
2 participants
@CurtHagenlocher @voidstar69